Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce AirflowPokeFailException #40923

Closed
wants to merge 1 commit into from
Closed

introduce AirflowPokeFailException #40923

wants to merge 1 commit into from

Conversation

raphaelauv
Copy link
Contributor

@raphaelauv raphaelauv commented Jul 22, 2024 •
edited
Loading

fix: #40787

Introduce a new exception AirflowSensorError AirflowPokeFailException that is part of the exceptions check by parameter soft_fail skip_policy = SkipPolicy.SKIP_ON_SOFT_ERROR.

Only providers using at least airflow 2.10.0 can use it , so until they can use AirflowSensorTimeout

@raphaelauv raphaelauv force-pushed the fix_soft_fail_part_2 branch 4 times, most recently from 18d5892 to a991609 Compare July 22, 2024 03:46
@raphaelauv raphaelauv force-pushed the fix_soft_fail_part_2 branch 4 times, most recently from 88ec4da to 7a94eee Compare July 22, 2024 05:03
eladkal
eladkal requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary blocking merge till we sort #40915 (comment)

@raphaelauv raphaelauv force-pushed the fix_soft_fail_part_2 branch 2 times, most recently from f1af651 to f849e01 Compare July 22, 2024 05:50
@raphaelauv raphaelauv mentioned this pull request Jul 22, 2024
Merged
eladkal
eladkal reviewed Jul 22, 2024
View reviewed changes
airflow/exceptions.py Outdated Show resolved Hide resolved
@raphaelauv
Copy link
Contributor Author

rebase on #40924

@raphaelauv raphaelauv changed the title fix: soft_fail part 2 introduce AirflowPokeFailException Jul 22, 2024
@raphaelauv raphaelauv force-pushed the fix_soft_fail_part_2 branch 2 times, most recently from 5afad7f to 7b3ef71 Compare July 25, 2024 16:50
@raphaelauv raphaelauv mentioned this pull request Jul 26, 2024
Merged
potiuk added a commit to potiuk/airflow that referenced this pull request Jul 26, 2024
@potiuk
Revert "Refactor BaseSensorOperator introduce skip_policy paramet…
5033ad4 
…er (apache#40924)"

This reverts commit ba78d54.

This is needed because provider tests started to fail and this one
should be combined and tested wiht apache#40923 including compatibility.
@potiuk potiuk mentioned this pull request Jul 26, 2024
Merged
potiuk added a commit that referenced this pull request Jul 26, 2024
@potiuk
Revert "Refactor BaseSensorOperator introduce skip_policy paramet…
e0ccaa9 
…er (#40924)" (#41045)

This reverts commit ba78d54.

This is needed because provider tests started to fail and this one
should be combined and tested wiht #40923 including compatibility.
@raphaelauv raphaelauv closed this Jul 26, 2024
@raphaelauv raphaelauv deleted the fix_soft_fail_part_2 branch July 26, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladkal eladkal eladkal requested changes

@o-nikolas o-nikolas Awaiting requested review from o-nikolas

@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

Assignees
No one assigned
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow area:providers provider:ftp provider:http provider:sftp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

soft_fail | operator is skipped in all cases and not only "data" related fail
2 participants
@raphaelauv @eladkal